/simplify cleanup: terminal-output path drift + counter→flag #3
Loading…
Reference in a new issue
No description provided.
Delete branch "simplify-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
/simplifytriplet result: reuse=PASS, efficiency=PASS, quality=WARNING. The 4 reuse findings + 9 efficiency findings were all NOT-WORTH-IT (repo too small for abstraction; no perf surface). The 3 quality findings are all in this PR.Fixes
install.sh+uninstall.sh"Next steps" output — the scripts told users to openSystem Settings → Keyboard → Input Sources/ scroll toOther/ addLatvian Apostrofs. The Tahoe-verified path (per the README + the screenshot during PR #1 install verification) isSystem Settings → Keyboard → Text Input → Edit…/ scroll toOthers/ addLatvian (apostrofs)(the picker label, lowercase, parens). The README was already right; the scripts were stale. Worst combination — users follow script output, not the README.ls -ladecoration dropped frominstall.sh. The post-copy[[ -f ]]validation block already proves both files landed; printing 54481-byte / 459-byte / mode-bit lines was noise the user can't act on.removedcounter →removedbool inuninstall.sh. The integer was only gating a single boolean ("did we touch anything?").removed=true/falseis the same shape with no arithmetic surface.Out of scope (per /simplify dialogue)
lib.shfor the sharedDEST+ filename pair → NOT-WORTH-IT (33+27 lines, two paired constants, indirection cost > duplication cost)defaults.run.shell→ NOT-WORTH-IT (two repetitions; explicit-at-step-top is more legible)shasum|awk,actions/checkoutcache,mktemp -dcleanup → all NOT-WORTH-IT (this is a once-per-reinstall personal-Mac script, no perf surface).keylayout/.icns— SHA-pinned, byte-for-byte preserved, explicitly excludedTest plan
HOME=/tmp/X bash install.sh && bash uninstall.sh && bash uninstall.sh(third invocation idempotent no-op) ✓/usr/local/bin/shellcheck✓ CLEANfindings=[]again perteika#60; operator-override APPROVED if so)🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Three findings from /simplify (reuse=PASS, efficiency=PASS, quality=WARNING): 1. **Path drift** — install.sh + uninstall.sh "Next steps" pointed users at the macOS pre-Tahoe Settings path (Input Sources / scroll to Other / "Latvian Apostrofs"). README + verified-on-Tahoe-26.4.1 evidence say the actual path is "Text Input → Edit…" / "Others" / "Latvian (apostrofs)" (the picker label, lowercase, parens). Worst combination was README right but script wrong, since users follow the script's terminal output. Now aligned. 2. **`ls -la` decoration** dropped from install.sh — the post-copy `[[ -f ]]` validation already proves both files landed; printing mode bits and byte sizes is noise the user can't act on. 3. **`removed` counter → `removed` bool** in uninstall.sh — the counter only gated a single boolean ("did we touch anything?"). `removed=true` is the same shape, one fewer arithmetic surface, and reads clearer. No CI changes. No data-file changes (.keylayout / .icns SHA-pinned, out of scope). Net diff: +8 / −10 across two scripts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>🤖 AI Review · Verdict: APPROVED ✅ (findings: [])
What was checked
install.shchange: stale Tahoe Settings path (Input Sources / Other / Latvian Apostrofs) replaced with verified path (Text Input → Edit… / Others / Latvian (apostrofs));ls -ladecoration removed; post-copy[[ -f ]]validation block intact.uninstall.shchange: counter→bool refactor with same semantics; same path-drift fix.set -euo pipefail,[[ -f ]]guards,cp -f/rm -fsemantics: unchanged./usr/local/bin/shellcheck).Final
No bugs. No vulnerabilities. Safe to merge.
Reviewed by Teika · clean output (no phantom_files flag) on a 2-file 8/10-line diff — contrast with PR #2's 50-line README-only diff which tripped
no_phantom_files. teika#60 still relevant for the verdict-derivation gap class.