fix: Complete conditional compilation guards for RADIO_DRIVER in UITa… #34

2025-12-26T20:13:51+02:00

okapteinis commented

2025-12-26 20:13:51 +02:00

(Migrated from github.com)

…sk.cpp

Wraps the HomePage::RADIO rendering section with #if RADIO_DRIVER_AVAILABLE guards to prevent compilation errors when radio_driver is not available.

This completes PR #33 fix by adding the actual conditional guards around the code that uses radio_driver symbols (specifically getNoiseFloor()), addressing the code review comment that the initial fix was incomplete.

Description

Type of Change

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature causing existing functionality to change)
Documentation update
Hardware support addition
Performance improvement

Testing Performed

Builds successfully on affected platforms
Tested on physical hardware
Verified no new compiler warnings
Checked memory usage
Example applications still work
Documentation updated

Hardware Tested

Device:
Firmware variant:
Test results:

Code Quality Checklist

Follows existing code style
No dynamic memory allocation in inappropriate places
No reformatting of existing code
Added comments for non-obvious logic
Updated documentation
CHANGELOG.md updated if applicable

Breaking Changes

Screenshots/Logs

Additional Notes

…sk.cpp Wraps the HomePage::RADIO rendering section with #if RADIO_DRIVER_AVAILABLE guards to prevent compilation errors when radio_driver is not available. This completes PR #33 fix by adding the actual conditional guards around the code that uses radio_driver symbols (specifically getNoiseFloor()), addressing the code review comment that the initial fix was incomplete. ## Description  ## Type of Change  - [ ] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [ ] Documentation update - [ ] Hardware support addition - [ ] Performance improvement ## Related Issues  ## Testing Performed  - [ ] Builds successfully on affected platforms - [ ] Tested on physical hardware - [ ] Verified no new compiler warnings - [ ] Checked memory usage - [ ] Example applications still work - [ ] Documentation updated ## Hardware Tested  - Device: - Firmware variant: - Test results: ## Code Quality Checklist - [ ] Follows existing code style - [ ] No dynamic memory allocation in inappropriate places - [ ] No reformatting of existing code - [ ] Added comments for non-obvious logic - [ ] Updated documentation - [ ] CHANGELOG.md updated if applicable ## Breaking Changes  ## Screenshots/Logs  ## Additional Notes

gemini-code-assist[bot] commented

2025-12-26 20:14:04 +02:00

(Migrated from github.com)

Summary of Changes

Hello @okapteinis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes a previous fix by implementing comprehensive conditional compilation guards for the RADIO_DRIVER functionality within UITask.cpp. The primary objective is to eliminate compilation errors that arise when radio_driver symbols are referenced in the UI code but the RADIO_DRIVER is not available, thereby improving the build robustness across different configurations and addressing a prior code review comment.

Highlights

Conditional Compilation Fix: Completes the conditional compilation guards for RADIO_DRIVER in UITask.cpp to prevent compilation errors when the radio driver is not available.
Code Guarding: Introduces #if RADIO_DRIVER_AVAILABLE and #endif directives around the HomePage::RADIO rendering section in UITask.cpp.
Error Prevention: Ensures that code referencing radio_driver symbols, such as getNoiseFloor(), is only compiled when RADIO_DRIVER_AVAILABLE is defined, resolving potential build failures.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩︎

## Summary of Changes Hello @okapteinis, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes a previous fix by implementing comprehensive conditional compilation guards for the `RADIO_DRIVER` functionality within `UITask.cpp`. The primary objective is to eliminate compilation errors that arise when `radio_driver` symbols are referenced in the UI code but the `RADIO_DRIVER` is not available, thereby improving the build robustness across different configurations and addressing a prior code review comment. ### Highlights * **Conditional Compilation Fix**: Completes the conditional compilation guards for `RADIO_DRIVER` in `UITask.cpp` to prevent compilation errors when the radio driver is not available. * **Code Guarding**: Introduces `#if RADIO_DRIVER_AVAILABLE` and `#endif` directives around the `HomePage::RADIO` rendering section in `UITask.cpp`. * **Error Prevention**: Ensures that code referencing `radio_driver` symbols, such as `getNoiseFloor()`, is only compiled when `RADIO_DRIVER_AVAILABLE` is defined, resolving potential build failures. <details> <summary>Using Gemini Code Assist</summary> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist). </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).

gemini-code-assist[bot] (Migrated from github.com) reviewed

2025-12-26 20:15:24 +02:00

gemini-code-assist[bot] (Migrated from github.com) left a comment

Code Review

This pull request correctly adds conditional compilation guards around radio-driver-specific UI code to prevent build errors when the radio driver is not available. The logic is sound. I've provided a couple of suggestions to align the formatting of the preprocessor directives with the prevailing style in the codebase for better consistency and readability.

## Code Review This pull request correctly adds conditional compilation guards around radio-driver-specific UI code to prevent build errors when the radio driver is not available. The logic is sound. I've provided a couple of suggestions to align the formatting of the preprocessor directives with the prevailing style in the codebase for better consistency and readability.

examples/companion_radio/ui-new/UITask.cpp

					
				@ -248,6 +248,7 @@ public:

				        display.print(tmp);

				      }

				    } else if (_page == HomePage::RADIO) {

				      #if RADIO_DRIVER_AVAILABLE

For better readability and consistency with the project's coding style (e.g., in main.cpp and UITask.h), preprocessor directives should not be indented. This also aligns with common C++ style guides, such as the Google C++ Style Guide, which recommends placing directives at the beginning of the line. Please remove the indentation for this #if directive.

#if RADIO_DRIVER_AVAILABLE

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) For better readability and consistency with the project's coding style (e.g., in `main.cpp` and `UITask.h`), preprocessor directives should not be indented. This also aligns with common C++ style guides, such as the Google C++ Style Guide, which recommends placing directives at the beginning of the line. Please remove the indentation for this `#if` directive. ```c #if RADIO_DRIVER_AVAILABLE ```

examples/companion_radio/ui-new/UITask.cpp

To maintain a consistent coding style, please remove the indentation for this #endif directive, placing it at the beginning of the line. This aligns with the project's existing style and common C++ conventions.

#endif

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) To maintain a consistent coding style, please remove the indentation for this `#endif` directive, placing it at the beginning of the line. This aligns with the project's existing style and common C++ conventions. ```c #endif ```

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ojars/MeshCore!34

Rows
Columns