ojars/MeshCore
Watch
1
0
Fork
You've already forked MeshCore
 0
Code Pull requests Projects Releases Packages Activity

Add conditional compilation guards for radio interface functions in t… #38

Merged
okapteinis merged 1 commit from feature/complete-radio-guards-comprehensive into nightly 2025-12-26 21:02:39 +02:00
Conversation 2 Commits 1 Files changed 1 +3
okapteinis commented 2025-12-26 21:02:30 +02:00 (Migrated from github.com)
Copy link

…arget.h

Description

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update
  • Hardware support addition
  • Performance improvement

Related Issues

Testing Performed

  • Builds successfully on affected platforms
  • Tested on physical hardware
  • Verified no new compiler warnings
  • Checked memory usage
  • Example applications still work
  • Documentation updated

Hardware Tested

  • Device:
  • Firmware variant:
  • Test results:

Code Quality Checklist

  • Follows existing code style
  • No dynamic memory allocation in inappropriate places
  • No reformatting of existing code
  • Added comments for non-obvious logic
  • Updated documentation
  • CHANGELOG.md updated if applicable

Breaking Changes

Screenshots/Logs

Additional Notes

…arget.h ## Description <!-- Provide a clear description of what this PR does --> ## Type of Change <!-- Mark relevant items with [x] --> - [ ] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [ ] Documentation update - [ ] Hardware support addition - [ ] Performance improvement ## Related Issues <!-- Link related issues: Fixes #123, Relates to #456 --> ## Testing Performed <!-- Describe testing done --> - [ ] Builds successfully on affected platforms - [ ] Tested on physical hardware - [ ] Verified no new compiler warnings - [ ] Checked memory usage - [ ] Example applications still work - [ ] Documentation updated ## Hardware Tested <!-- List hardware tested, or write "N/A" if documentation-only --> - Device: - Firmware variant: - Test results: ## Code Quality Checklist - [ ] Follows existing code style - [ ] No dynamic memory allocation in inappropriate places - [ ] No reformatting of existing code - [ ] Added comments for non-obvious logic - [ ] Updated documentation - [ ] CHANGELOG.md updated if applicable ## Breaking Changes <!-- Describe any breaking changes and migration path, or write "None" --> ## Screenshots/Logs <!-- Add screenshots or serial logs if applicable --> ## Additional Notes <!-- Any additional information for reviewers -->
gemini-code-assist[bot] commented 2025-12-26 21:02:41 +02:00 (Migrated from github.com)
Copy link

Summary of Changes

Hello @okapteinis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build process by implementing conditional compilation for radio interface functions. By wrapping these function declarations within preprocessor directives, the system can selectively include or exclude radio-related code based on whether a radio driver is available. This change improves build flexibility and efficiency, particularly for environments where radio hardware may not always be present or desired.

Highlights

  • Conditional Compilation: This pull request introduces conditional compilation guards (#if RADIO_DRIVER_AVAILABLE and #endif) around the declarations of radio interface functions in target.h. This ensures that these functions are only included in the build if the RADIO_DRIVER_AVAILABLE macro is defined, allowing for more flexible compilation based on hardware capabilities or build configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩︎

## Summary of Changes Hello @okapteinis, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the build process by implementing conditional compilation for radio interface functions. By wrapping these function declarations within preprocessor directives, the system can selectively include or exclude radio-related code based on whether a radio driver is available. This change improves build flexibility and efficiency, particularly for environments where radio hardware may not always be present or desired. ### Highlights * **Conditional Compilation**: This pull request introduces conditional compilation guards (`#if RADIO_DRIVER_AVAILABLE` and `#endif`) around the declarations of radio interface functions in `target.h`. This ensures that these functions are only included in the build if the `RADIO_DRIVER_AVAILABLE` macro is defined, allowing for more flexible compilation based on hardware capabilities or build configurations. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
gemini-code-assist[bot] (Migrated from github.com) reviewed 2025-12-26 21:03:48 +02:00
gemini-code-assist[bot] (Migrated from github.com) left a comment
Copy link

Code Review

This pull request adds conditional compilation guards for the radio interface function declarations in target.h, which is a good step towards making radio support optional. However, this change is incomplete and will introduce build errors as the corresponding function definitions in target.cpp are not guarded. I've added a critical comment highlighting this issue. I've also included a minor style suggestion to improve code consistency.

## Code Review This pull request adds conditional compilation guards for the radio interface function declarations in `target.h`, which is a good step towards making radio support optional. However, this change is incomplete and will introduce build errors as the corresponding function definitions in `target.cpp` are not guarded. I've added a critical comment highlighting this issue. I've also included a minor style suggestion to improve code consistency.
variants/sensecap_indicator_d1l/target.h
@ -51,3 +52,4 @@
void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
void radio_set_tx_power(uint8_t dbm);
mesh::LocalIdentity radio_new_identity();
#endif
gemini-code-assist[bot] (Migrated from github.com) commented 2025-12-26 21:03:48 +02:00
Copy link

critical

While adding this conditional compilation guard for the function declarations is correct, the corresponding function definitions in variants/sensecap_indicator_d1l/target.cpp have not been similarly guarded. This will lead to build failures when RADIO_DRIVER_AVAILABLE is not defined, as the functions will be defined but not declared. Please wrap the implementations of radio_init, radio_get_rng_seed, radio_set_params, radio_set_tx_power, and radio_new_identity in target.cpp with the same #if RADIO_DRIVER_AVAILABLE guard.

![critical](https://www.gstatic.com/codereviewagent/critical.svg) While adding this conditional compilation guard for the function declarations is correct, the corresponding function definitions in `variants/sensecap_indicator_d1l/target.cpp` have not been similarly guarded. This will lead to build failures when `RADIO_DRIVER_AVAILABLE` is not defined, as the functions will be defined but not declared. Please wrap the implementations of `radio_init`, `radio_get_rng_seed`, `radio_set_params`, `radio_set_tx_power`, and `radio_new_identity` in `target.cpp` with the same `#if RADIO_DRIVER_AVAILABLE` guard.
variants/sensecap_indicator_d1l/target.h
@ -52,2 +53,4 @@
void radio_set_tx_power(uint8_t dbm);
mesh::LocalIdentity radio_new_identity();
#endif
gemini-code-assist[bot] (Migrated from github.com) commented 2025-12-26 21:03:48 +02:00
Copy link

medium

This added blank line is unnecessary and can be removed to maintain a clean and consistent coding style.

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) This added blank line is unnecessary and can be removed to maintain a clean and consistent coding style.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ojars/MeshCore!38
No description provided.