refactor(d1l): dead-code cleanup + software/firmware README (behavior-preserving) #53
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/fork-owned-simplify"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Two behavior-preserving changes scoped to the fork's own code — readability / dedup / structure only, no functional change.
1. docs: replace
CLAUDE.mdwith a software+firmwareREADME.md(3bc770a)Retire the AI-assistant-oriented
CLAUDE.md; fold its durable content intoREADME.md, reorganised for humans into two sections:src/), protocol summary, host tooling (d1l_logger.py, PlatformIO), dependencies.2. refactor(d1l): remove dead debug-comment corpses + unused constant (
0ea2eb8)variants/sensecap_indicator_d1l/target.cpp: drop ~26// Serial…; // REMOVEDdebug corpses + a commented-out PSRAM block + the unusedConfig::JPEG_HEADER_SIZE; foldif(!initStorage()){}else{...}into the equivalentif(initStorage()){...}; preserve the genuine "why" notes (no early Serial in HAL window; PSRAM diagnostics disabled) as real comments.Verification
SenseCapIndicator-D1L_repeaterbuilds clean before and after:firmware.binbyte-identical (1,703,520 B), RAM 24.5%, Flash 51.0%, 0 warnings (-Wall -Wextra). The refactor changes nothing in the compiled output.Scope notes
thinknode_m3/m6,rak11310,nibble_screen_connect) currently do not compile onnightly(pre-existing errors:AutoDiscoverRTCClock/rtc_clock/BLE_PIN_CODE), so they have no green baseline and were intentionally excluded from this behavior-preserving pass.🤖 Generated with Claude Code
Behavior-preserving cleanup of variants/sensecap_indicator_d1l/target.cpp: - drop ~26 commented-out `// Serial…; // REMOVED` debug corpses and a commented-out PSRAM diagnostics block (noise that obscured real logic); - remove the unused `Config::JPEG_HEADER_SIZE` constexpr (referenced nowhere; the live check uses `JPEG_MAGIC_HEADER_SIZE`); - fold `if(!initStorage()){}else{...}` into `if(initStorage()){...}` (equivalent); - preserve the load-bearing "why" notes (no early Serial in HAL window; PSRAM diagnostics disabled) as real comments. No functional change: firmware.bin is byte-identical to the pre-refactor build (1,703,520 B), RAM/Flash unchanged, 0 warnings (-Wall -Wextra). Honours the repo rule against retroactive reformatting — only dead code removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Codex hygiene disposition — 2026-08-13
Live recheck of PR #53:
0ea2eb8bd6ec2985a41734836216e6990e92ed7dis based on currentnightly55e6f81143bb31e3150b5b56893c05600ba722eb; no rebase is required.CLAUDE.mdremoval, README restructuring, andtarget.cppdead-comment/unused-constant cleanup): 3 files, 88 insertions, 853 deletions.has_issues=false, so this repository cannot accept a separate issue for the hygiene decision.Disposition: the PR is still technically current and remains a candidate for merge after council review. Codex cannot merge it because the PR author is
ojars, while the Codex operating policy permits Codex to merge only Codex-authored PRs. The authorized owner should perform the final merge after council approval, or explicitly close it if the refactor is no longer wanted.Council review evidence — 2026-08-13
Teika review of commit
0ea2eb8bd6ec2985a41734836216e6990e92ed7dreturned APPROVED with no code or security findings.The local verification attempt used PlatformIO
native_test; PlatformIO installed the native toolchain into an isolated temporary core directory, but the build is blocked by pre-existing missing project dependencies (Arduino.h,Stream.h,SHA256.h). This does not provide a green build claim.The PR remains current against
nightly(55e6f81) and mergeable. Final merge remains with the authorized owner because this PR isojars-authored and Codex may merge only Codex-authored PRs.Adjudication: read Codex's 2026-08-13 council-review-evidence comment in full — Teika review of
0ea2eb8returned APPROVED with no code or security findings. Diff is behavior-preserving (docs restructure + dead-comment/unused-constant removal intarget.cpp), scoped to the fork's own code. No findings to adjudicate. Localnative_testbuild remained unverified (missing Arduino/PlatformIO framework headers in the isolated test env — expected for embedded firmware code outside its real board toolchain, not a defect in this diff). Operator reviewed and authorized merge. Merging now.